Fix broken allocation test on 1.5 #605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wrapping the `@allocated` call in `@test` seems to be triggering an allocation.
tkoolen
force-pushed
the
tkoolen/no-broken-allocated
branch
from
10fa55e
to
5c83c76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping the
@allocatedcall in@testseems to be triggering an allocation; probably some compiler limit being triggered? Using@ballocatedfrom BenchmarkTools (JuliaCI/BenchmarkTools.jl#157),) seems like a more robust way to measure.Ref JuliaLang/julia#27270 and JuliaLang/julia#33717.